Extract template registry to its own class #158
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the complexity of creating, persisting, loading, and retrieving
BinData::Struct
instances from the local- and file-based caches by extracting the relevant code and the necessary threadsafety mutexes into a new thread-safe class calledTemplateRegistry
.This new class has two main entry points:
TemplateRegistry.register(key, fields)
: in a thread-safe manner and respecting the codec's@cache_ttl
, register the given list of fields as a newBinData::Struct
, persisting to disk if configured to do so.TemplateRegistry.fetch(key)
: in a thread-safe manner, retrieve theBinData::Struct
that has been registered with the given key.It uses the existing tests to prove itself.
There is a minor change in behaviour to this implementation that surfaces in non-happy-path scenarios: when encountering a corrupt file, an unwritable file, or any other exception reading or writing the file, this implementation logs an error and continues instead of crashing the codec and potentially its input.