fixed encryption base64 encoding bug, +random ivs, + cipher reuse #2
Conversation
fixed encryption base64 encoding bug
fix for "uninitialized constant LogStash::Filters::Cipher::OpenSSL"
fixed error on nil/blank source field
added support for random iv's
fix hard wired 16 iv length
added max_cipher_reuse to permit re-use of the cipher instance rather than forcing re-creates over and over
|
Can this just be merged, then I can re-fork and fix the indentation. Getting confused as to how to properly do it at this point. The commits above seem to reference my orignal PR commits, but when I make an edit there, the latest commit is not showing up (indent fix) bitsofinfo/logstash-contrib@c1d434e |
| # | ||
| # For AES algorithms set this to a 16 byte string. | ||
| # | ||
| # filter { cipher { iv => "1234567890123456" }} |
There was a problem hiding this comment.
I think this should be 5 spaces, not space + tab
# filter ...
|
Can someone please give me a tip on where I should make these changes? My original changes are here: https://github.com/bitsofinfo/logstash-contrib/blob/master/lib/logstash/filters/cipher.rb Should I just make my changes there, and submit another PR?.... which I don't think will work because these are entirely 2 different projects now... |
…gstash-contrib#79 This incorporates those changes plus those requested for the new plugin location at: logstash-plugins#2
|
Please close this PR, it is replaced by #3 |
|
replaced by #3 |
…gstash-contrib#79 * plus changes requested for the new plugin location at: #2 * incorporate PR #7 changes (strict b64 usage) * note about JCE policy files, key sizes
closes #1