Switched time string comparation to Timestamp comparable to avoiding problems due to precision loss

[andsel]

Release notes

Fix spec and unit tests after introduction of nanosecond precision in Logstash with elastic/logstash#12797

What does this PR do?

This PR switched time comparations in specs and unit test from String to org.logstash.Timestamp to avoid problems due to loss of precision.

The PR elastic/logstash#12797 introduced nanosecond precision into Logstash, a similar problem happened also into JDBC plugin and here is implemented the same solution described in the original comment.

Why is it important/What is the impact to the user?

It doesn't impact the user, it's only related to tests

Checklist

• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have made corresponding change to the default configuration files (and/or docker env variables)
• I have added tests that prove my fix is effective or that my feature works

Author's Checklist

• [ ]

How to test this PR locally

• run ./gradlew test on a JDK 11

Related issues

Use cases

Screenshots

The problem could be seen at https://app.travis-ci.com/github/logstash-plugins/logstash-filter-date/jobs/545405353#L528

Logs

logstash_1_f52dffb2a8a0 | <=====--------> 42% EXECUTING [8s]> :compileTestJava<=====--------> 42% EXECUTING [9s]<===========--> 85% EXECUTING [9s]> :test<===========--> 85% EXECUTING [10s]<===========--> 85% EXECUTING [11s]<===========--> 85% EXECUTING [12s]> :test > Resolve files of :testRuntimeClasspath> :test > 0 tests completed<===========--> 85% EXECUTING [13s]> :test > Executing test org.logstash.filters.parser.JodaParserTest<===========--> 85% EXECUTING [14s]> :test > 2 tests completed> :test > Executing test org.logstash.filters.parser.UnixEpochParserTest> :test > 16 tests completed> :test > 162 tests completed> :test > 178 tests completed> :test > Executing test org.logstash.filters.DateFilterTest<===========--> 85% EXECUTING [15s]<===========--> 85% EXECUTING [16s]<===========--> 85% EXECUTING [17s]<===========--> 85% EXECUTING [18s]> :test > 180 tests completedlogstash_1_f52dffb2a8a0 | > Task :test
logstash_1_f52dffb2a8a0 | 
logstash_1_f52dffb2a8a0 | org.logstash.filters.DateFilterTest > testIsoStrings FAILED
logstash_1_f52dffb2a8a0 |     java.lang.AssertionError at DateFilterTest.java:210
logstash_1_f52dffb2a8a0 | 
logstash_1_f52dffb2a8a0 | org.logstash.filters.DateFilterTest > testUnixLongs FAILED
logstash_1_f52dffb2a8a0 |     java.lang.AssertionError at DateFilterTest.java:210
logstash_1_f52dffb2a8a0 | 
logstash_1_f52dffb2a8a0 | org.logstash.filters.DateFilterTest > testIsoStringsInterpolateTz FAILED
logstash_1_f52dffb2a8a0 |     java.lang.AssertionError at DateFilterTest.java:210
logstash_1_f52dffb2a8a0 | 
logstash_1_f52dffb2a8a0 | org.logstash.filters.DateFilterTest > testUnixInts FAILED
logstash_1_f52dffb2a8a0 |     java.lang.AssertionError at DateFilterTest.java:210
logstash_1_f52dffb2a8a0 | 
logstash_1_f52dffb2a8a0 | 
logstash_1_f52dffb2a8a0 | 
logstash_1_f52dffb2a8a0 | <===========--> 85% EXECUTING [18s]> :test > 186 tests completed, 4 failed> :test > Executing test org.logstash.filters.DateFilterTestlogstash_1_f52dffb2a8a0 | org.logstash.filters.DateFilterTest > testPatternStringsInterpolateTzNoYear FAILED
logstash_1_f52dffb2a8a0 |     java.lang.AssertionError at DateFilterTest.java:210
logstash_1_f52dffb2a8a0 | 
logstash_1_f52dffb2a8a0 | org.logstash.filters.DateFilterTest > testUnixStrings FAILED
logstash_1_f52dffb2a8a0 |     java.lang.AssertionError at DateFilterTest.java:210
logstash_1_f52dffb2a8a0 | 
logstash_1_f52dffb2a8a0 | 
logstash_1_f52dffb2a8a0 | 
logstash_1_f52dffb2a8a0 | <===========--> 85% EXECUTING [18s]> :test > 188 tests completed, 6 failedlogstash_1_f52dffb2a8a0 | 188 tests completed, 6 failed
loggstash_1_f52dffb2a8a0 | logstash_1_f52dffb2a8a0 | 
logstash_1_f52dffb2a8a0 | <===========--> 85% EXECUTING [19s]> :testlogstash_1_f52dffb2a8a0 | > Task :test FAILED

[andsel]

@yaauie in the comment you noted that the implementation of Data filter needs to switch from Joda to java.time, this PR is intended to be a bugfix to get the tests green again.

[yaauie]

LGTM ❇️

[yaauie]

we've now added this matcher to two plugins, and should probably consider adding it to our shared devutils spec helper.

[andsel]

HI @yaauie thanks for pointing it out, I've created issue elastic/logstash-devutils#98 to track it.
I've aligned to master and bumped the version of this plugins to be published, so I ask you a quick second review

[andsel]

Updated the dependency to devutils >= 2.3 to reuse the be_a_logstash_timestamp_equivalent_to matcher

[yaauie]

Actual changes LGTM.

I don't think we need to bump the version, and we could improve the changelog to be more use-centric.

[yaauie]

LGTM 🌮

Thank you for getting those shared assertions upstream into devutils!

[yaauie]

🎉