Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle more errors gracefully #49

Merged
merged 1 commit into from
Feb 8, 2019
Merged

Handle more errors gracefully #49

merged 1 commit into from
Feb 8, 2019

Conversation

robbavey
Copy link
Contributor

@robbavey robbavey commented Feb 8, 2019

Certain classes of errors could cause the plugin to crash (for
example trying to resolve an address with a label with > 63 characters)
This commit adds some more error handling to log error and skip the 
event

@robbavey
Handle more errors gracefully
fe9d056 
Certain classes of errors could cause the plugin to crash (for
example trying to resolve an address with a label with > 63 characters)
This commit adds some more error handling to log error and skip the 
event
@elasticsearch-bot elasticsearch-bot self-assigned this Feb 8, 2019
colinsurprenant
colinsurprenant approved these changes Feb 8, 2019
View reviewed changes
Copy link
Contributor

@colinsurprenant colinsurprenant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaauie
Copy link
Contributor

yaauie commented Feb 8, 2019

@robbavey I've got another patch in flight with #48, can roll them both into a patch release momentarily.

@yaauie yaauie merged commit fe9d056 into logstash-plugins:master Feb 8, 2019
yaauie added a commit that referenced this pull request Feb 8, 2019
@yaauie
Merge branch 'backport-underqualified-domain-fix', remote-tracking br…
ad6d1f1 
…anch 'robbavey/improve_error'

Closes: #48
Closes: #49

Resolves: #38
Resolves: #31
@robbavey
Copy link
Contributor Author

Thanks @yaauie!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinsurprenant colinsurprenant colinsurprenant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@robbavey @yaauie @colinsurprenant @elasticsearch-bot