Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify connection to Elasticsearch #150

Merged
merged 5 commits into from Oct 11, 2021
Merged

Verify connection to Elasticsearch #150

merged 5 commits into from Oct 11, 2021

Conversation

andsel
Copy link
Contributor

@andsel andsel commented Aug 18, 2021 •
edited

This PR updated the elasticsearch-ruby client to version 7.14.0.

@andsel andsel force-pushed the feature/add_elasticsearch_check_before_connecting branch from 3f169b3 to c04b1af Compare August 19, 2021 11:02
@roaksoax roaksoax requested a review from jsvd September 21, 2021 14:44
@andsel andsel force-pushed the feature/add_elasticsearch_check_before_connecting branch from 2068681 to b8b013c Compare September 21, 2021 15:13
@andsel andsel marked this pull request as ready for review September 21, 2021 15:14
jsvd
jsvd reviewed Sep 27, 2021
View reviewed changes
Copy link
Contributor

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change LGTM but we should have a better error message before proceeding with merging.

@andsel andsel force-pushed the feature/add_elasticsearch_check_before_connecting branch from 42a8b44 to 18a8b05 Compare September 29, 2021 15:54
@andsel andsel requested a review from jsvd October 4, 2021 09:06
jsvd
jsvd approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andsel andsel merged commit 9fefde9 into logstash-plugins:master Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsvd jsvd jsvd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andsel @jsvd @roaksoax