Add Elastic Api Version header #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
blocked for now by elastic/elastic-transport-ruby#66 |
…asticsearch into add_eav_header # Conflicts: # CHANGELOG.md # logstash-filter-elasticsearch.gemspec
kaisecheng
force-pushed
the
add_eav_header
branch
from
6fbd357
to
ed05fe2
Compare
kaisecheng
commented
Sep 27, 2023
| @@ -478,6 +479,15 @@ def test_connection! | |||
| end | |||
| end | |||
|
|
|||
| def test_serverless_connection! | |||
| begin | |||
| get_client.client.info(:headers => LogStash::Filters::ElasticsearchClient::DEFAULT_EAV_HEADER ) if get_client.serverless? | |||
There was a problem hiding this comment.
use info instead of ping because the error message from ping is insufficient
jsvd
reviewed
Sep 28, 2023
jsvd
approved these changes
Sep 28, 2023
Co-authored-by: João Duarte <jsvd@users.noreply.github.com>
|
@jsvd tried to recreate the client. If the last commit doesn't make sense, I would like to revert it |
|
link the issue for cleaning up resources #175 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds "Elastic-Api-Version" : "2023-10-31" to request header for serverless