Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding an option to specify an index, fix of a huge mistake in current documentation, rewriting of hosts handling to have working ssl in Logstash 2.3, adding transport_options to enable advanced underlying Transport Options. #31

Closed
wants to merge 6 commits into from

Conversation

jehuty0shift
Copy link
Contributor

@jehuty0shift jehuty0shift commented May 18, 2016

Hello,
This is a pretty simple Pull Request to enable a new setting "index". This setting allows you to specify which Elasticsearch Index you want to query.

PS. I have signed the Logstash agreement shortly. Is it possible to check it again ?

@karmi
Copy link

karmi commented May 18, 2016

Hi @jehuty0shift, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

@jehuty0shift
Copy link
Contributor Author

Hi @karmi, Thanks for your reply ! Sorry for that, I just added my commit e-mail to my account then.

@jehuty0shift jehuty0shift changed the title adding support to specify an index for the query adding an option to specify an index for the query and fixing a huge mistake in current documentation. May 19, 2016
@jehuty0shift jehuty0shift changed the title adding an option to specify an index for the query and fixing a huge mistake in current documentation. adding an option to specify an index, fix of a huge mistake in current documentation, rewriting of hosts handling to have working ssl in Logstash 2.3, adding transport_options to enable advanced underlying Transport Options. May 26, 2016
@jehuty0shift
Copy link
Contributor Author

jehuty0shift commented May 26, 2016

I change the implementation of hosts and options to have a working ssl in Logstash 2.3, I added Transport options option to let users provide more advanced options in the Default Faraday Transport used by the Elasticsearch Client. the User and Password are now handled directly by the underlying Elasticsearch Client.

@purbon
Copy link

purbon commented Jun 16, 2016

Thanks a lot for your contribution @jehuty0shift I'm doing some maintenance here and took some of your commits for a bigger PR where I will include some changes pending here. see #36 for details.

@purbon purbon closed this Jun 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants