Force encoding to UTF-8 when concatenating sources to generate finger… #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…print To get around jruby/jruby#6748, force the encoding to UTF-8 This issue causes events containing arrays of hashes which include non US-ASCII characters to crash the plugin if concatenating sources: Example event that would previously cause an issue: {"top_level":"ง","inner":[{"inner_key":"ง"},{"1":"2"}]} This commit forces encoding of intermediate results when concatenating to UTF-8 to get around this issue Fixes logstash-plugins#63
kaisecheng
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…print
To get around jruby/jruby#6748, force the encoding to UTF-8.
This issue causes events containing arrays of hashes which include non US-ASCII
characters to crash the plugin if concatenating sources:
Example event that would previously cause an issue:
{"top_level":"ง","inner":[{"inner_key":"ง"},{"1":"2"}]}
This commit forces encoding of intermediate results when concatenating to UTF-8 to
get around this issue
Fixes #63