Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Grok - Fix missing quotes for field matching #183

Closed
wants to merge 1 commit into from

Conversation

ugosan
Copy link

@ugosan ugosan commented Oct 25, 2022

Fix missing quotes for field matching

Fix missing quotes for field matching
@wallrik
Copy link
Contributor

wallrik commented Oct 25, 2022

This is the 4th PR addressing the same thing 😅 I've had one open for 5 months... 😁 %{NUMBER"number} needs a colon instead of the quote, as well.

@ugosan
Copy link
Author

ugosan commented Oct 26, 2022

lets address all those in a single PR then

@wallrik
Copy link
Contributor

wallrik commented Oct 26, 2022

lets address all those in a single PR then

For sure! If you're able to merge to this repo, my PR (#176) should already be sufficient, and has been reviewed. 👍

I just had to comment when I saw your Elastic team tag. 😇 I'm not familiar with merge procedures at Elastic and why nothing is getting merged over here for months. If it's the build tests failing? That's possibly an ecs_compatibility issue? (#178)

@jsvd
Copy link
Contributor

jsvd commented Oct 28, 2022

fixed in #176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants