Fix tag on failure test #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Field Reference can handle special characters in 8.3.0
kaisecheng
changed the title
|
@logstashmachine bump patch |
1 task
mashhurs
reviewed
May 11, 2023
| if (Gem::Requirement.create('>= 7.0').satisfied_by?(logstash_version) || | ||
|
|
||
| # Field Reference can handle special characters since 8.3.0 | ||
| if ((Gem::Requirement.create('>= 7.0').satisfied_by?(logstash_version) && Gem::Requirement.create('< 8.3').satisfied_by?(logstash_version)) || |
There was a problem hiding this comment.
Do we have or can we add test cases for 8.3+ LS versions?
There was a problem hiding this comment.
we have existing test for tagging json fail for 8.3+
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Field Reference can handle special characters in 8.3.0. This commit excludes the failed test from 8.3+
Related:
elastic/logstash#11941
Close #55