Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Can't modify frozen string" error when converting boolean to string #171

Merged

Conversation

edmocosta
Copy link
Contributor

@edmocosta edmocosta commented Nov 22, 2023

This PR fixes the "Can't modify frozen string" error when converting from boolean to string in Logstash 8.11.


Closes: #170

@edmocosta edmocosta force-pushed the fix-convert-with-frozen-strings branch from 25aa827 to df4779e Compare November 22, 2023 13:13
@edmocosta edmocosta force-pushed the fix-convert-with-frozen-strings branch from 96de963 to c5f28bb Compare November 22, 2023 13:20
@edmocosta edmocosta changed the title [WIP] Fix "Can't modify frozen string" error when converting booleans to string Fix "Can't modify frozen string" error when converting boolean to string Nov 22, 2023
@edmocosta edmocosta marked this pull request as ready for review November 22, 2023 13:42
spec/filters/mutate_spec.rb Outdated Show resolved Hide resolved
Copy link
Contributor

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: João Duarte <jsvd@users.noreply.github.com>
@edmocosta edmocosta merged commit b0b923f into logstash-plugins:main Nov 22, 2023
2 checks passed
@edmocosta edmocosta deleted the fix-convert-with-frozen-strings branch November 22, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error converting boolean values in Logstash 8.11.1: Can't modify frozen string
3 participants