Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for numeric values and avoid @target verification, some cleanups #36

Merged
merged 2 commits into from Jan 4, 2019
Merged

fix for numeric values and avoid @target verification, some cleanups #36

merged 2 commits into from Jan 4, 2019

Conversation

colinsurprenant
Copy link
Contributor

Fixes #13

The following example was crashing because of numeric values

$ bin/logstash -e 'input {stdin {codec => json_lines}} filter{split{field => "a"}} output{stdout {codec => rubydebug}}'
...
{"a":[1,2,3]}

This PR fixed the numeric case and also adds an optimization to avoid checking for @target for every cloned events. Also adds corresponding specs.

@colinsurprenant colinsurprenant mentioned this pull request Jan 3, 2019
Closed
@elasticsearch-bot elasticsearch-bot self-assigned this Jan 3, 2019
@yaauie yaauie assigned yaauie and unassigned elasticsearch-bot Jan 3, 2019
yaauie
yaauie approved these changes Jan 3, 2019
View reviewed changes
Copy link
Contributor

@yaauie yaauie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@yaauie
Copy link
Contributor

yaauie commented Jan 3, 2019

Changelog & Version Bump please 😄

@colinsurprenant colinsurprenant merged commit 5670ae4 into logstash-plugins:master Jan 4, 2019
@colinsurprenant
Copy link
Contributor Author

Ignoring unrelated build error, published 3.1.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaauie yaauie yaauie approved these changes

Assignees

@yaauie yaauie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split filter not working on an array of numbers
3 participants
@colinsurprenant @yaauie @elasticsearch-bot