Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove work-around for Mac OS version extraction #70

Open
kares opened this issue Mar 24, 2021 · 0 comments
Open

remove work-around for Mac OS version extraction #70

kares opened this issue Mar 24, 2021 · 0 comments

Comments

@kares
Copy link
Contributor

kares commented Mar 24, 2021

a work-around was introduced with the 0.12.0 UA regexes update at: #69

the issue is tracked upstream as: ua-parser/uap-core#504
when resolved the plugin should update regexes.yaml and skip patching the file:

// work-around a 'regression' with extracting Mac OS version, without the '?'
// the pattern would extract major: '18', minor: '2' from agent strings like:
// "MacOutlook/16.24.0.190414 (Intelx64 Mac OS X Version 10.14.4 (Build 18E226))"
line.replace("- regex: 'Mac OS X\\s.{1,50}\\s(\\d+).(\\d+).(\\d+)'", "- regex: 'Mac OS X\\s.{1,50}?\\s(\\d+).(\\d+).(\\d+)'")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant