-
Notifications
You must be signed in to change notification settings - Fork 36
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix: capture os major + update UA regexes (#69)
* Test: drop (confusing) insist expectations * Refactor: dry-out string dup-ing * Test: add some UTF-8 string asserts * Refactor: and test behavior on raised errors * Refactor: move field name setup to initialize * Fix: remove unused (never filled) event field * Fix: detect 'major' OS version (even if no minor) this is useful to detect Windows majors: 'Vista', '10' * Fix: update to latest UA regexes for accurate matching * Fix: [bracketed] target field configuration * Fix: work-around Mac OS version matching regression
- Loading branch information
Showing
7 changed files
with
252 additions
and
99 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.