Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/remove dependencies #393

Merged
merged 4 commits into from Jun 3, 2020
Merged

Conversation

robbavey
Copy link
Contributor

@robbavey robbavey commented May 11, 2020

This commit updates the following dependencies:

Jackson-databind to 2.9.10.4
Netty to 4.1.49.final

Additionally, this commit removes the dependency on tcnative +
boringssl based on the work done by @jsvd in #384, which enables the update of netty dependencies while still allowing logstash->logstash communication via the lumberjack
output plugin. (boringssl removed compatibility with CBC ciphers, which
are still a prerequisite for lumberjack output plugin support at this time)

@robbavey
Copy link
Contributor Author

In addition to the integration tests, this commit was tested against this script created by @jsvd to exercise this issue where the IdleStateHandler was holding back acknowledgements.

Running this script to completion:

Beats Input 6.0.5:

real	1m3.108s
user	0m10.231s
sys	0m0.539s

6.0.9:

real	0m3.223s
user	0m10.363s
sys	0m0.485s

This commit:

real	0m3.231s
user	0m10.295s
sys	0m0.585s

@robbavey robbavey requested a review from jsvd May 12, 2020 14:51
Copy link
Contributor

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
please bump, squash and 🚢

@robbavey
Copy link
Contributor Author

@jsvd - one thing to note, this will break on versions of Java 8 without the JCE Unlimited Strength Jurisdiction Policy installed. From Java 1.8.0_162 onwards (released January 2018), the policy was installed by default, but prior to this release, these ciphers are not all present, leading to a plugin failure.

I can update the plugin to be more lenient, and warn on missing ciphers, and only fail when no ciphers are available. WDYT?

@jsvd
Copy link
Contributor

jsvd commented May 14, 2020

I think it's fine that we detect if jce isn't available (maybe through the maximum cipher lenght which should be 128 w/o jce), we exclude the aes 256 ciphers:

          "TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384",
          "TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384",
          "TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA384",
          "TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384",

This commit updates the following dependencies:

Jackson-databind to `2.9.10.4`
Netty to `4.1.49.final`

Additionally, this commit removes the dependency on `tcnative` +
`boringssl` from logstash-plugins#384, which enables the update of netty dependencies
while still allowing logstash->logstash communication via the lumberjack
output plugin. (`boringssl` removed compatibility with `CBC` ciphers, which
are still a prerequisite for lumberjack output plugin support at this time,
While it is been the default for Java since JDK 8u161 released in early 2018,
old versions of Java may not have the JCE unlimited strength jurisdiction policy
installed. This commit handles this case, warning the user that the policy is not
installed, and presenting a reduced set of default ciphers for use.
@robbavey
Copy link
Contributor Author

@jsvd I've made the changes and updated the changelog and bumped the version - do you think the version should be a minor or patch update?

@jsvd
Copy link
Contributor

jsvd commented May 27, 2020

I'd vote on patch as a it's a fix and doesn't introduce any new user facing capability

@robbavey
Copy link
Contributor Author

Done

Copy link
Contributor

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robbavey robbavey merged commit d017289 into logstash-plugins:master Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants