Importing the old repo into this one #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se the new logstash-core gem.
Allow for greater flexibility around polling metrics from multiple namespaces. Fixes logstash-plugins#1
- Break the run method into smaller methods - Make some logging statements info - Merge in the dimension and metric parameters - Remove method name confusion - Fixes logstash-plugins#12 - Fixes logstash-plugins#7
Fixes logstash-plugins#9 Clean up some dependencies
| @@ -0,0 +1,3 @@ | |||
| source 'https://rubygems.org' | |||
| ruby "1.9.3", :engine => "jruby", :engine_version => "1.7.19" | |||
There was a problem hiding this comment.
Why this line? can we remove it?
There was a problem hiding this comment.
See this for an explanation: logstash-plugins/logstash-input-example#3
|
@jrgns can you add tests? Even if they are mocks should be ok |
|
I've added some boilerplate for tests and a single test to check that the register method works. |
suyograo
pushed a commit
that referenced
this pull request
Feb 9, 2016
Importing the old repo into this one
|
@jrgns thanks. I merged and bumped version to 1.1.0. Can you please add |
|
@suyograo Done Awesome, thanx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.