-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: unify event updates to happen in one place #297
Conversation
on `RSpec::Expectations::ExpectationNotMetError`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor question/nit.
spec/inputs/file_read_spec.rb
Outdated
@@ -363,7 +363,9 @@ def wait_for_start_processing(run_thread, timeout: 1.0) | |||
end | |||
end | |||
|
|||
def wait_for_file_removal(path, timeout: 3 * interval) | |||
wait(timeout).for { File.exist?(path) }.to be_falsey | |||
def wait_for_file_removal(path, timeout: interval) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the timeout
parameter used anywhere, can we remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is a simple refactoring to have
event.set
in one place for easy understanding.There's also 2 minor changes to make CI more stable - properly re-trying on rspec expectation failure