Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change field name. #41

Closed
wants to merge 1 commit into from
Closed

Change field name. #41

wants to merge 1 commit into from

Conversation

yfhong
Copy link

@yfhong yfhong commented Jan 13, 2016

Field name conflict with collectd json metric.

Field name conflict with collectd json metric.
@elasticsearch-release
Copy link

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

@untergeek
Copy link

Changing a field name is a breaking change. This will need to be mentioned in the Changelog, the version number increased to the next major number, and thoroughly documented.

Can you please explain where the collision is? I understand that you have two field names colliding, but if they're both string values, why is that a conflict?

@jsvd
Copy link
Contributor

jsvd commented May 11, 2018

this has been solved by #68

@jsvd jsvd closed this May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants