Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Prepared Statement support #349

Merged
merged 7 commits into from Sep 9, 2019
Merged

Add Prepared Statement support #349

merged 7 commits into from Sep 9, 2019

Conversation

guyboertje
Copy link
Contributor

Code, tests, docs and version bump.

@colinsurprenant
Copy link

Great work @guyboertje - left a few minor comments but otherwise LGTM!

robbavey
robbavey reviewed Sep 5, 2019
View reviewed changes
Copy link
Contributor

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff @guyboertje - comments are mostly nits

docs/index.asciidoc Show resolved Hide resolved
docs/index.asciidoc Show resolved Hide resolved
lib/logstash/inputs/jdbc.rb Outdated Show resolved Hide resolved
lib/logstash/plugin_mixins/jdbc/statement_handler.rb Outdated Show resolved Hide resolved
lib/logstash/plugin_mixins/jdbc/value_tracking.rb Outdated Show resolved Hide resolved
spec/inputs/jdbc_spec.rb Outdated Show resolved Hide resolved
spec/inputs/jdbc_spec.rb Outdated Show resolved Hide resolved
robbavey
robbavey approved these changes Sep 9, 2019
View reviewed changes
Copy link
Contributor

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - happy with the changes that you've made!

colinsurprenant
colinsurprenant approved these changes Sep 9, 2019
View reviewed changes
Copy link

@colinsurprenant colinsurprenant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guyboertje guyboertje merged commit c7c91c4 into logstash-plugins:master Sep 9, 2019
@guyboertje guyboertje deleted the prep-statements branch September 9, 2019 15:17
@karenzone karenzone mentioned this pull request Jan 29, 2020
Closed
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinsurprenant colinsurprenant colinsurprenant approved these changes

@robbavey robbavey robbavey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@guyboertje @colinsurprenant @robbavey