Change doc to recommend beats input as alternative #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danhermann
reviewed
Mar 27, 2019
docs/index.asciidoc
Outdated
| @@ -33,6 +33,8 @@ https://github.com/elastic/logstash-forwarder[logstash-forwarder] | |||
| tool that has been replaced by | |||
| https://github.com/elastic/beats/tree/master/filebeat[Filebeat]. | |||
|
|
|||
| NOTE: Consider using the {logstash-ref}/plugins-inputs-beats.html[beats input plugin] instead. | |||
| The Beats input implements the old and the new lumberjack protocol. | |||
There was a problem hiding this comment.
I would suggest capitalizing Beats and Lumberjack. Also, the mention of the old and new Lumberjack protocols might be confusing given that they are not discussed anywhere else. I'd suggest something along the lines of "the Beats input is actively developed and backward-compatible with the Lumberjack input."
There was a problem hiding this comment.
If we retain the phrase the old and the new, would it be appropriate to clarify the protocol versions? Something like:
old (v1) and the new (v2) lumberjack protocol.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated documentation in response to a customer support issue