Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional flag to decompress file without having 'gz' extention #165

Closed
gurupritmukhraiya opened this issue Sep 25, 2018 · 6 comments · Fixed by #168
Closed

Optional flag to decompress file without having 'gz' extention #165

gurupritmukhraiya opened this issue Sep 25, 2018 · 6 comments · Fixed by #168

Comments

@gurupritmukhraiya
Copy link

We are using S3 input plugin to pull data from S3, we are using kinesis firehose to push data to S3, which does not adds 'gz' extension to the files, but data is in zipped format.

S3 input plugin is pulling data from S3 it can only decompress the data which has gz as extension since while code walk through we we notice there is a condition checking 'gz' as extension then only it decompress the file data.

We do not want to maintain the custom plugin at our end just for small change.

I just wanted to ask can we add a flag over there, which can be set as configuration and used with that condition, so that even files which use can set intentionally to decompress files does not have 'gz' extension or with any extension.

Can you provide such feature as same plugin or can we contribute to this input plugin, if yes how and what is the process for the same?

@gurupritmukhraiya
Copy link
Author

Hi,

Just wanted to have an update on this,

  1. Did you feel this issue is a candidate to be implemented in coming updates?
  2. If yes, How long it would be available so that we can utilize this?

It would be great if this can be provided ASAP, since we would not need to implement patchy things at our end.
Thanks!!!

@blangenfeld
Copy link
Contributor

Hey @gurupritmukhraiya , I've opened PR #168. Maybe it'll help you.

@gurupritmukhraiya
Copy link
Author

gurupritmukhraiya commented Nov 30, 2018 via email

@blangenfeld
Copy link
Contributor

It's up to the maintainers to determine whether/when the PR gets merged.

@blangenfeld
Copy link
Contributor

@jsvd , is there anything more that must be done to get the PR reviewed & merged in?

The build "failed", but it seems to be because Travis choked on something unrelated. Not sure how to proceed here...

@lenfree
Copy link

lenfree commented Jan 12, 2019

Any update on this? I am in need of this where Cloudwatch logs is already compressed before Firehose stream to S3. ATM, I am running my version of S3 input but as much as possible I would like not to maintain my own.

lenfree added a commit to packetloop/packetloop_s3 that referenced this issue Jan 14, 2019
bucket. This is a breaking change from S3 input plugin and meant to
be temporary until PR
logstash-plugins/logstash-input-s3#165
merge
lenfree added a commit to packetloop/packetloop_s3 that referenced this issue Jan 14, 2019
bucket. This is a breaking change from S3 input plugin and meant to
be temporary until PR
logstash-plugins/logstash-input-s3#165
merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants