Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc]Add example for exclude pattern #204

Merged
merged 5 commits into from
Apr 16, 2020
Merged

[Doc]Add example for exclude pattern #204

merged 5 commits into from
Apr 16, 2020

Conversation

karenzone
Copy link
Contributor

@karenzone karenzone added the docs label Apr 15, 2020
@elasticsearch-bot elasticsearch-bot self-assigned this Apr 15, 2020
karenzone and others added 3 commits April 16, 2020 09:42
@karenzone @yaauie
Update docs/index.asciidoc
720009f 
Co-Authored-By: Ry Biesemeyer <yaauie@users.noreply.github.com>
@karenzone
Minor edits
9620b8d
@karenzone
Add new line
aea25c5
karenzone
karenzone commented Apr 16, 2020
View reviewed changes
Copy link
Contributor Author

@karenzone karenzone left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds cleanly with suggestions added. Thanks for adding the tip.

yaauie
yaauie approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@yaauie yaauie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 LGTM

@karenzone karenzone merged commit 01d9287 into logstash-plugins:master Apr 16, 2020
@karenzone karenzone deleted the example-exclude branch April 16, 2020 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaauie yaauie yaauie approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Doc]Mismatch between table and detail ordering document example of exclude_pattern usage
3 participants
@karenzone @yaauie @elasticsearch-bot