Fix a few issues regarding the s3 input #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ph
commented
Feb 17, 2015
ph
commented
- Allow the user to define where the plugin should keep his temporary files
- Bugfix, If a S3 object key exactly match the prefix we will skip it fixes Setting up a prefix in logstash make him treat it like an actual file #10
- Use info instead of error when using a user defined sincedb_path
- adding integration test
- Move back the GZIP file and the normal file logic back into the plugin.
|
@purbon I wish I had your rspec presentation before writing this. Could you review/test? |
|
Jajaja, will do! |
|
@purbon review? |
|
@suyograo will do, will do, hope to do it today. |
|
We will need to yank LogStash::Codecs::GzipLines and LogStash::Codecs::Cloudfront and remove the two repositories since I have moved back the functionality into the S3 input. https://github.com/logstash-plugins/logstash-codec-cloudfront and https://github.com/logstash-plugins/logstash-codec-gzip_lines |
|
@ph reviewing |
| else | ||
| decorate(event) | ||
|
|
||
| event["cloudfront_version"] = metadata[:cloudfront_version] unless metadata[:cloudfront_version].nil? |
There was a problem hiding this comment.
I would avoid as much as possible the usage of unless, is more clean when you use if not. But this is a personal style test.
* Allow the user to define where the plugin should keep his temporary files * Bugfix, If a S3 object key exactly match the prefix we will skip it fixes logstash-plugins#10 * Use info instead of error when using a user defined sincedb_path adding integration test
ph
force-pushed
the
fix/bring-gzip-inside
branch
from
4fb0023
to
6c47c77
Compare
|
Merged sucessfully into master! |
This was referenced Mar 4, 2015
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.