Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix example configuration in docs #195

Merged
merged 2 commits into from May 17, 2021
Merged

Fix example configuration in docs #195

merged 2 commits into from May 17, 2021

Conversation

alex-stiff
Copy link
Contributor

If the keys are quoted as in the previous version of the documentation, this results in errors like this:

[ERROR] 2020-02-21 10:53:27.345 [LogStash::Runner] s3 - Unknown setting '"bucket"' for s3

Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/

@alex-stiff
Fix example configuration in docs
d1a44c6 
If the keys are quoted as in the previous version of the documentation, this results in errors like this:
```
[ERROR] 2020-02-21 10:53:27.345 [LogStash::Runner] s3 - Unknown setting '"bucket"' for s3
```
@cla-checker-service
Copy link

cla-checker-service bot commented Feb 21, 2020 •
edited

💚 CLA has been signed

kaisecheng
kaisecheng requested changes May 17, 2021
View reviewed changes
Copy link
Contributor

@kaisecheng kaisecheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving our doc. The change looks good. Could you sign the Contributor Agreement to unblock me to merge this PR?

@alex-stiff
Copy link
Contributor Author

Thanks for improving our doc. The change looks good. Could you sign the Contributor Agreement to unblock me to merge this PR?

Thanks kaisecheng. I've signed the Contributor Agreement.

@kaisecheng kaisecheng merged commit d2238f7 into logstash-plugins:master May 17, 2021
@kaisecheng kaisecheng requested review from kaisecheng and removed request for kaisecheng May 17, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaisecheng kaisecheng kaisecheng requested changes

Assignees
No one assigned
Labels
missing cla status:changes-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alex-stiff @kaisecheng @kares @roaksoax