Fix missing file because of cutoff time change #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cutoff time calculation part is using Time.now But if file list to check is too many, sometimes Time.now will be change seconds. example) previous loop : Time.now => 2021-04-06T20:13:59.996 current loop : Time.now => 2021-04-06T20:14:00.001 If two files have same modified second, first file is not process for next cycle. The other is processed and update sincedb. When next cycle, first file is not processed because first file's modified time is same sincedb. If current_time will be get before loop, there will be no missing files.
kaisecheng
approved these changes
Apr 27, 2021
|
The fix will be in the next release 3.7.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cutoff time calculation part is using Time.now
But if file list to check is too many, sometimes Time.now will be change seconds.
example)
previous loop : Time.now => 2021-04-06T20:13:59.996
current loop : Time.now => 2021-04-06T20:14:00.001
If two files have same modified second, first file is not process for next cycle.
The other is processed and update sincedb.
When next cycle, first file is not processed because first file's modified time is same sincedb.
If current_time will be getted before loop and use current_time in loop , there will be no missing files.
Related Issue
#227
Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/