Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump public_suffix version #77

Merged
merged 2 commits into from Nov 16, 2023
Merged

Bump public_suffix version #77

merged 2 commits into from Nov 16, 2023

Conversation

edmocosta
Copy link
Contributor

@edmocosta edmocosta commented Oct 25, 2023 •
edited

Bumped public_suffix gem version to > 4 < 6

Closes: #76

@edmocosta edmocosta changed the title [WIP] Bump public_suffix version Bump public_suffix version Nov 7, 2023
@edmocosta edmocosta marked this pull request as ready for review November 7, 2023 10:42
@edmocosta edmocosta self-assigned this Nov 7, 2023
roaksoax
roaksoax approved these changes Nov 13, 2023
View reviewed changes
Copy link

@roaksoax roaksoax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@edmocosta edmocosta merged commit b3b5738 into logstash-plugins:main Nov 16, 2023
2 checks passed
@edmocosta edmocosta deleted the bump-public_suffix branch November 16, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roaksoax roaksoax roaksoax approved these changes

Assignees

@edmocosta edmocosta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plugin doesn't work with Logstash 8.10+
2 participants
@edmocosta @roaksoax