Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix external documentation links. #35

Merged
merged 2 commits into from Aug 4, 2023

Conversation

roaksoax
Copy link
Contributor

@roaksoax roaksoax commented Jul 7, 2023

What does this PR do?

Updates links to external documentation.

Closes #17

@roaksoax roaksoax added the docs label Jul 7, 2023
@cla-checker-service
Copy link

cla-checker-service bot commented Jul 7, 2023

💚 CLA has been signed

@@ -109,7 +109,7 @@ This plugin uses the AWS SDK and supports several ways to get credentials, which
* Default value is `{}`

Key-value pairs of settings and corresponding values used to parametrize
the connection to s3. See full list in https://docs.aws.amazon.com/sdkforruby/api/Aws/S3/Client.html[the AWS SDK documentation]. Example:
the connection to s3. See full list in https://docs.aws.amazon.com/sdk-for-ruby/v3/api/Aws/S3/Client.html[the AWS SDK documentation]. Example:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karenzone Note to self: Set up variable for easier versioning

@karenzone karenzone self-assigned this Jul 14, 2023
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with this as in now. If versions change frequently and require manual update, we can revisit setting variables.

@roaksoax roaksoax merged commit ac4adf2 into logstash-plugins:main Aug 4, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links to AWS API from documentation mostly point to v2 of the API rather than v3
2 participants