Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSL support and update clients #18

Merged
merged 12 commits into from Nov 7, 2023

Conversation

edmocosta
Copy link
Contributor

@edmocosta edmocosta commented Oct 18, 2023

Release notes

  • Updated Enterprise Search clients to version >= 7.16, < 9, adding also support to the following SSL configurations: ssl_certificate_authorities, ssl_truststore_path, ssl_truststore_password, ssl_truststore_type, ssl_verification_mode, ssl_supported_protocols and ssl_cipher_suites.
  • [BREAKING] Swiftype endpoints are no longer supported for both plugins App Search and Workplace Search. The App Search deprecated options host and path were removed.
  • Fixed the sprintf format support for the Workplace Search source configuration

What does this PR do?

Why is it important/What is the impact to the user?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

Related issues

@edmocosta edmocosta marked this pull request as ready for review October 26, 2023 14:12
@edmocosta edmocosta changed the title [WIP] Add SSL support and update clients Add SSL support and update clients Oct 26, 2023
Copy link
Contributor

@andsel andsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The general PR seems good, but there a couple of points that need clarification, plus a couple of syntax related things.

lib/logstash/outputs/elastic_app_search.rb Outdated Show resolved Hide resolved
lib/logstash/outputs/elastic_app_search.rb Outdated Show resolved Hide resolved
lib/logstash/outputs/elastic_workplace_search.rb Outdated Show resolved Hide resolved
lib/logstash/outputs/elastic_workplace_search.rb Outdated Show resolved Hide resolved
lib/logstash/outputs/elastic_workplace_search.rb Outdated Show resolved Hide resolved
lib/logstash/plugin_mixins/enterprise_search/client.rb Outdated Show resolved Hide resolved
logstash-integration-elastic_enterprise_search.gemspec Outdated Show resolved Hide resolved
spec/fixtures/certificates/generate.sh Show resolved Hide resolved
@andsel andsel self-assigned this Nov 3, 2023
@andsel andsel self-requested a review November 6, 2023 14:49
Copy link
Contributor

@andsel andsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edmocosta
Copy link
Contributor Author

All the latest changes seems to be working fine! Thanks for your help, @andsel! ✅

@andsel
Copy link
Contributor

andsel commented Nov 6, 2023

Hi @yaauie, thank's a lot for your review. I've integrated your suggestion and the PR is ready for a second round of review 🙏

@edmocosta edmocosta merged commit 92f2d4e into logstash-plugins:main Nov 7, 2023
2 checks passed
@edmocosta edmocosta deleted the update-clients-and-add-ssl branch November 7, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logstash - Plugins - SSL Settings Standardization - Add SSL support to Elastic app/workplace search plugins
2 participants