New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SSL support and update clients #18
Add SSL support and update clients #18
Conversation
57f5fa4
to
03d4dcf
Compare
03d4dcf
to
0b42751
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The general PR seems good, but there a couple of points that need clarification, plus a couple of syntax related things.
lib/logstash/plugin_mixins/enterprise_search/manticore_transport.rb
Outdated
Show resolved
Hide resolved
lib/logstash/plugin_mixins/enterprise_search/manticore_transport.rb
Outdated
Show resolved
Hide resolved
…of class names which could end in wrong class usage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ced in version 7.17
All the latest changes seems to be working fine! Thanks for your help, @andsel! ✅ |
|
Release notes
>= 7.16
,< 9
, adding also support to the following SSL configurations:ssl_certificate_authorities
,ssl_truststore_path
,ssl_truststore_password
,ssl_truststore_type
,ssl_verification_mode
,ssl_supported_protocols
andssl_cipher_suites
.host
andpath
were removed.sprintf
format support for the Workplace Searchsource
configurationWhat does this PR do?
Why is it important/What is the impact to the user?
Checklist
Related issues