Ensure target option is defined in Lookups when ECS is enabled
#71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…citly for logstash-filter-jdbc_static
andsel
force-pushed
the
feature/enable_ecs_for_jdbc_filter_static
branch
from
bb023d0
to
70a9004
Compare
kares
suggested changes
May 25, 2021
Instead of direct access to @ecs_compatibility it uses the accessor method Co-authored-by: Karol Bucek <kares@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the validation of
targetsub-option in the blocks oflocal_lookupsforlogstash-filter-jdbc_static.The
targetattribute already existed, in this case it's only added a check that it's valued in case ECS is enabled.Related to PR #69
Related to issue #19