normalize loading of JDBC driver classes #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normalizing the class name to always have a Java:: prefix is helpful since JRuby is only able to directly load class names whose top-level package is com, org, java, javax, while there are many jdbc drivers that use cc, io, net, and others.
kares
reviewed
Oct 27, 2021
Co-authored-by: Karol Bucek <kares@users.noreply.github.com>
kares
approved these changes
Oct 27, 2021
yaauie
reviewed
Oct 27, 2021
Co-authored-by: Ry Biesemeyer <yaauie@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normalizing the class name to always have a Java:: prefix
is helpful since JRuby is only able to directly load class names
whose top-level package is com, org, java, javax, while there are
many jdbc drivers that use cc, io, net, and others.
fixes #31