Doc:Add attribute for kafka client versions #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karenzone
force-pushed
the
attr-kafka-version
branch
2 times, most recently
from
723623d
to
aaa06c1
Compare
Replaced hard-coded kafka client and doc path version numbers with attributes to simplify maintenance
karenzone
force-pushed
the
attr-kafka-version
branch
from
aaa06c1
to
a515c2c
Compare
karenzone
commented
Aug 12, 2020
| Depending on your broker configuration, this can be | ||
| either when the record was created (default) or when it was received by the | ||
| broker. See more about property log.message.timestamp.type at | ||
| https://kafka.apache.org/{kafka_client_doc}/documentation.html#brokerconfigs |
There was a problem hiding this comment.
Yikes! Here's an oldie!
karenzone
commented
Aug 12, 2020
| and | ||
| https://kafka.apache.org/25/javadoc/org/apache/kafka/common/errors/InterruptException.html[InterruptException]. | ||
| https://kafka.apache.org/{kafka_client_doc}/javadoc/org/apache/kafka/common/errors/InterruptException.html[InterruptException]. |
There was a problem hiding this comment.
This link using /25/ is from a recent PR. Seems like we should standardize it, too. WDYT?
There was a problem hiding this comment.
👍 most definitely - for correctness these should point to /24 till we upgrade the client
|
@kares I replaced the hard-coded values for kafka client and the kafka version in links with attributes. The goal is to have one place to set the values in each file. Then all of the other references will be updated automatically. |
karenzone
changed the title
kares
approved these changes
Aug 13, 2020
|
Thanks for the review, kares! <3 |
|
This PR is included in changelog/version bump for #46 |
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces hard-coded kafka client version with an attribute to make updating it easier