Fix support for basic auth with the schema registry #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue with supporting basic auth when using the schema registry The plugin currently expects 'schema_registry_secret` and `schema_registry_key` to be set to authenticate with the schema registry. However, while this works during the 'register' phase, the authentication type `basic.auth.credentials.source` is not set when creating the kafka consumer, leading to authentication failures when attempting to deserialize the kafka payload. This commit correctly sets the `basic.auth.credentials.source` to `USER_INFO` when `schema_registry_key` and `schema_registry_secret` are set, and also enables the use of a basic auth embedded in the `schema_registry_url` via `username:password@url`
|
This fixes #95 |
robbavey
force-pushed
the
basic_auth_schema
branch
6 times, most recently
from
0bc06b1
to
873b2dc
Compare
robbavey
force-pushed
the
basic_auth_schema
branch
from
873b2dc
to
717eed5
Compare
robbavey
force-pushed
the
basic_auth_schema
branch
from
9c72fa1
to
807b96e
Compare
andsel
approved these changes
Jun 29, 2021
CHANGELOG.md
Outdated
| @@ -1,3 +1,7 @@ | |||
| ## 10.7.7 | |||
| - Fix: Correct the settings to allow basic auth to work properly, either by setting 'schema_registry_key/secret` or embedding username/password in the | |||
There was a problem hiding this comment.
Suggested change
| - Fix: Correct the settings to allow basic auth to work properly, either by setting 'schema_registry_key/secret` or embedding username/password in the | |
| - Fix: Correct the settings to allow basic auth to work properly, either by setting `schema_registry_key/secret` or embedding username/password in the |
| @@ -292,37 +317,58 @@ def delete_remote_schema(schema_registry_client, subject_name) | |||
| expect( subjects ).to be_empty | |||
| end | |||
| end | |||
| end | |||
|
|
|||
| def cleanup_schema_registry | |||
There was a problem hiding this comment.
cleanup_schema_registry reminds me something that's cleaned on the Schema Registry service instead of a "shutdown Schema Registry" action
This was referenced Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with supporting basic auth when using the schema registry
The plugin currently expects
schema_registry_secretandschema_registry_keytobe set to authenticate with the schema registry. However, while this works during the
'register' phase, the authentication type
basic.auth.credentials.sourceis not setwhen creating the kafka consumer, leading to authentication failures when attempting
to deserialize the kafka payload.
This commit correctly sets the
basic.auth.credentials.sourcetoUSER_INFOwhenschema_registry_keyandschema_registry_secretare set, and also enables the useof a basic auth embedded in the
schema_registry_urlviausername:password@url