Doc: Remove outdated recommendation for settings #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robbavey @psanz-estc What else is needed? Any further guidance we can provide? |
robbavey
approved these changes
Jul 13, 2021
There was a problem hiding this comment.
I'm good with this - it removes confusing and out of date information from the docs. I think there's a broader issue around our use of defaults for this plugin, how they relate to the defaults from the kafka library and the appropriateness of those defaults for Logstash, but that is a bigger task than this one and removing stale information is important.
tl;dr: LGTM
|
100% agreed. We haven't solved the broader settings/document issue because it's not easy to solve. At least this is a small step in the right direction. |
|
Published at v10.8.1: https://rubygems.org/gems/logstash-integration-kafka/versions/10.8.1-java |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a setting recommendation that is no longer accurate for Kafka 2.0+.
Fixes: #20