Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify the error behaviour for template installation and ilm #1146

Closed
kaisecheng opened this issue Aug 7, 2023 · 0 comments · Fixed by #1151
Closed

Unify the error behaviour for template installation and ilm #1146

kaisecheng opened this issue Aug 7, 2023 · 0 comments · Fixed by #1151
Assignees
@kaisecheng
Labels
bug Team:Logstash

Comments

@kaisecheng
Copy link
Contributor

We have two behaviors on errors in template and ilm.

  1. The plugin logs error message and is allowed to process events when it fails to install template, such as failing to read the template file.
  2. The plugin loops with error and is unable to handle events when it fails ilm check, such as policy not found.

The ideal outcome is to throw the errors and stop the corresponding pipeline when user's configuration is wrong and unable to finish the register phase
@kaisecheng kaisecheng changed the title Unify the error behaviour for install template and ilm Unify the error behaviour for template installation and ilm Aug 7, 2023
@kaisecheng kaisecheng mentioned this issue Aug 7, 2023
Merged
@kaisecheng kaisecheng mentioned this issue Sep 21, 2023
Merged
@kaisecheng kaisecheng linked a pull request Sep 22, 2023 that will close this issue
shut down pipeline when finish register fails #1151
Merged
@jsvd jsvd closed this as completed in #1151 Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaisecheng kaisecheng

Labels
bug Team:Logstash
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

shut down pipeline when finish register fails kaisecheng/logstash-output-elasticsearch
2 participants
@roaksoax @kaisecheng