Add support to Serverless Elasticsearch #1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pool stores build flavour in health check to determinate if the Elasticsearch is serverless. In serverless, ilm, legacy template API, license checker are disabled and the plugin throws ConfigurationError when ilm_enabled => true or template_api => legacy
kaisecheng
changed the title
jsvd
reviewed
Aug 7, 2023
jsvd
approved these changes
Aug 9, 2023
| plugin.logger.trace("Resolving ILM template settings: template doesn't have 'settings' or 'template' fields, falling back to auto detection", :template => template, :template_api => plugin.template_api, :es_version => plugin.maximum_seen_major_version, :template_endpoint => template_endpoint) | ||
| template_endpoint == INDEX_TEMPLATE_ENDPOINT ? | ||
| composable_index_template_settings(template) : | ||
| use_index_template = index_template?(plugin) |
There was a problem hiding this comment.
Since we're not really using templates here, but figuring out which API for templating to use, maybe a better name:
Suggested change
| use_index_template = index_template?(plugin) | |
| use_index_template_api = index_template_api?(plugin) |
Co-authored-by: João Duarte <jsvd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pool stores build flavour in health check to determinate if the Elasticsearch is serverless.
In serverless, ilm, legacy template API and license checker are disabled. The plugin throws ConfigurationError when ilm_enabled => true or template_api => legacy
todo: add integration test against serverless
fixes: https://github.com/elastic/ingest-dev/issues/2277