More fixes to Elasticsearch output build #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Later versions of the Elasticsearch mandate a `name` parameter to the `exists_alias` method. This commit updates the tests to include that parameter. Additionally, there are some fixes to move towards an "inclusion" list of policies to delete, rather than an "exclusion" list.
robbavey
force-pushed
the
more_test_fixes
branch
from
26edb4a
to
ea608d0
Compare
kares
approved these changes
Feb 27, 2020
| @@ -139,7 +139,7 @@ def put_alias(client, the_alias, index) | |||
| end | |||
|
|
|||
| def clean_ilm(client) | |||
| client.get_ilm_policy.each_key { |key| client.delete_ilm_policy(name: key) unless key =~ /history-ilm-policy/ } | |||
| client.get_ilm_policy.each_key { |key| client.delete_ilm_policy(name: key) if key =~ /logstash-policy/ } | |||
There was a problem hiding this comment.
👍 to have a logstash- prefix convention and only delete what specs create!
|
Thanks @kares! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Later versions of the Elasticsearch mandate a
nameparameter to theexists_aliasmethod. This commit updates the tests to include thatparameter.
Additionally, there are some fixes to move towards an "inclusion" list
of policies to delete, rather than an "exclusion" list.