Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade email dependency to fix the Ruby net-smtp load regression. #69

Merged
merged 3 commits into from Oct 3, 2023
Merged

Upgrade email dependency to fix the Ruby net-smtp load regression. #69

merged 3 commits into from Oct 3, 2023

Conversation

mashhurs
Copy link
Contributor

@mashhurs mashhurs commented Sep 28, 2023 •
edited by andsel

Description

output-email plugin with Logstash 8.10+ versions raises a LoadError: no such file to load -- net/smtp error.
It is due to ruby 3.1 regression that marks net-smtp as a bundled gem: ruby/ruby#4530

Solution

output-email plugin uses mail gem and bundled net-smtp gem with ruby 3.1 support was added: mikel/mail@d9d8dcc
So, we need to update mail dependency to 2.8.+ versions.

@mashhurs mashhurs self-assigned this Sep 28, 2023
@mashhurs
Copy link
Contributor Author

🔴 CI is a transient.

@roaksoax roaksoax requested a review from jsvd October 2, 2023 14:30
jsvd
jsvd requested changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With mail 2.8, mime-types is no longer a dependency (replaced by mini-mime), so we can remove it.

logstash-output-email.gemspec Outdated Show resolved Hide resolved
logstash-output-email.gemspec Outdated Show resolved Hide resolved
@mashhurs @jsvd
Apply suggestions from code review
66b53f7 
Remove mime-types dependency.

Co-authored-by: João Duarte <jsvd@users.noreply.github.com>
@mashhurs
Copy link
Contributor Author

mashhurs commented Oct 3, 2023

🔴 CI is a transient.

@mashhurs mashhurs requested a review from jsvd October 3, 2023 14:59
jsvd
jsvd approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mashhurs mashhurs merged commit ef33cca into logstash-plugins:main Oct 3, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsvd jsvd jsvd approved these changes

Assignees

@mashhurs mashhurs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LoadError: no such file to load -- net/smtp
2 participants
@mashhurs @jsvd