Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove (missing function) jruby check when opening fifos #75

Merged
merged 1 commit into from Jan 3, 2019
Merged

remove (missing function) jruby check when opening fifos #75

merged 1 commit into from Jan 3, 2019

Conversation

jmakar
Copy link
Contributor

@jmakar jmakar commented Nov 21, 2018

Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/

@jsvd jsvd requested a review from guyboertje November 27, 2018 22:27
@jmakar
Copy link
Contributor Author

jmakar commented Jan 3, 2019

Any word on this gentlemen? The CLA was signed btw.

jsvd
jsvd approved these changes Jan 3, 2019
View reviewed changes
Copy link
Contributor

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsvd jsvd merged commit 38ad57b into logstash-plugins:master Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsvd jsvd jsvd approved these changes

@guyboertje guyboertje Awaiting requested review from guyboertje

Assignees
No one assigned
Labels
missing cla
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jmakar @jsvd