(Docs Only) Fixed inaccuracies in documentation #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @josephlewis42 Nice to see you again. Your changes look good! Everything builds cleanly without error. Thanks for keeping your plugin docs up-to-date. Here's a screenshot showing how the new info you added to Either way is fine, and I don't have a preference. Thanks again! -K
|
karenzone
approved these changes
Sep 11, 2018
|
@karenzone, merged. Thanks for checking this out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @karenzone would you mind reviewing these updates to the docs for BigQuery?
I was talking with @alepuccetti in #45 and he noted that the docs were out of sync with the official BigQuery recommendations and limits.
I fixed that, changed a few instances of "logstash" to "Logstash" and included some re-worded official documentation where appropriate.