Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chnage concurrency to :shared and publish outside of synchronized code #60

Closed
wants to merge 1 commit into from
Closed

Chnage concurrency to :shared and publish outside of synchronized code #60

wants to merge 1 commit into from

Conversation

honzakral
Copy link
Contributor

Fixes #59

@josephlewis42 josephlewis42 self-requested a review January 5, 2021 16:55
@josephlewis42
Copy link
Contributor

I think this looks good. I've been out of Ruby development for about a year now so it would help for someone else to take a peek.

@jsvd jsvd self-requested a review January 5, 2021 17:18
@karenzone
Copy link
Contributor

@honzakral Thanks for making this change. It appears to be ready to merge.

@jsvd
Copy link
Member

jsvd commented Jan 14, 2021

merged in 1196273

@jsvd jsvd closed this Jan 14, 2021
@jsvd
Copy link
Member

jsvd commented Jan 14, 2021

this has been released as v4.1.4. thanks for the contribution @honzakral and review @josephlewis42!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsvd jsvd jsvd left review comments

@josephlewis42 josephlewis42 josephlewis42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Batches should be published in paralel when using multiple pipeline workers
4 participants
@honzakral @josephlewis42 @karenzone @jsvd