Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Replace cross-document links with attributes #61

Merged
merged 4 commits into from
Jan 15, 2021

Conversation

karenzone
Copy link
Contributor

@karenzone karenzone commented Jan 12, 2021

Standardize links to Elastic docs to use shared attributes.
Correct link to Quotas and LImits to close #58
Bump to v.4.1.5

@karenzone karenzone added the docs label Jan 12, 2021
Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* Events will be flushed when <<plugins-{type}s-{plugin}-batch_size>>, <<plugins-{type}s-{plugin}-batch_size_bytes>>, or <<plugins-{type}s-{plugin}-flush_interval_secs>> is met, whatever comes first.
If you notice a delay in your processing or low throughput, try adjusting those settings.

===== Additional Resources

* https://cloud.google.com/docs/authentication/production[Application Default Credentials (ADC) Overview]
* https://cloud.google.com/bigquery/[BigQuery Introduction]
* https://cloud.google.com/bigquery/quota[BigQuery Quotas and Limits]
* https://cloud.google.com/bigquery/quotas[BigQuery Quotas and Limits]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@jsvd
Copy link
Member

jsvd commented Jan 15, 2021

@karenzone I'll publish once the PR is merged, as the normal publishing process isn't working on this plugin

@karenzone karenzone merged commit 5f9242d into logstash-plugins:master Jan 15, 2021
@karenzone karenzone deleted the shared-attributes branch January 15, 2021 15:32
@karenzone
Copy link
Contributor Author

@jsvd. Thanks for the review and for publishing. ❤️

@jsvd
Copy link
Member

jsvd commented Jan 15, 2021

Published as 4.1.5 https://rubygems.org/gems/logstash-output-google_bigquery/versions/4.1.5-java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC]Link to bigquery doc results in 404
3 participants