Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RFC5424 timestamp output #8

Closed
wants to merge 1 commit into from
Closed

Fix RFC5424 timestamp output #8

wants to merge 1 commit into from

Conversation

daph
Copy link
Contributor

@daph daph commented Jul 8, 2015

This fixes issue #3, "RFC5424 output seems to format zone offset incorrectly"

Adding the second 'Z' to the timestamp format outputs the offset with the colon (see date format docs here). I tested this with syslog-ng as the receiving syslog and it now happily accepts RFC5424 messages sent to it via logstash-output-syslog where before it complained and wouldn't parse them.

@suyograo
Copy link
Contributor

@daph can you rebase please?

@daph
Copy link
Contributor Author

daph commented Aug 21, 2015

@suyograo Rebase done.

@suyograo
Copy link
Contributor

@daph
Copy link
Contributor Author

daph commented Aug 21, 2015

@suyograo I could have sworn I already did, but oh well. I just went and signed it all now.

@suyograo suyograo closed this Aug 21, 2015
@suyograo suyograo reopened this Aug 21, 2015
@suyograo
Copy link
Contributor

@daph make sure to sign the CLA with the same email as the one you use for commit. I see a skytap email here, but I think you signed with a different one.

@suyograo
Copy link
Contributor

@daph if it helps, you can also create a brand new PR with the new email.

@daph
Copy link
Contributor Author

daph commented Aug 21, 2015

@suyograo Woops, sorry about that. Didn't realize that's the email I have for the commit. Is it fine if I just resign the CLA again, but with the skytap email?

Edit: I just went ahead and signed again with the skytap email. I'll probably have commits under that email in the future anyway.

@suyograo suyograo closed this Aug 21, 2015
@suyograo suyograo reopened this Aug 21, 2015
@suyograo
Copy link
Contributor

CLA check ok. LGTM. manually merging

@suyograo suyograo closed this Aug 21, 2015
@suyograo suyograo reopened this Aug 21, 2015
@suyograo suyograo closed this in df4d80d Aug 21, 2015
@suyograo
Copy link
Contributor

@daph thanks for your patience and contribution to Logstash!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants