-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RFC5424 timestamp output #8
Conversation
@daph can you rebase please? |
@suyograo Rebase done. |
@suyograo I could have sworn I already did, but oh well. I just went and signed it all now. |
@daph make sure to sign the CLA with the same email as the one you use for commit. I see a skytap email here, but I think you signed with a different one. |
@daph if it helps, you can also create a brand new PR with the new email. |
@suyograo Woops, sorry about that. Didn't realize that's the email I have for the commit. Is it fine if I just resign the CLA again, but with the skytap email? Edit: I just went ahead and signed again with the skytap email. I'll probably have commits under that email in the future anyway. |
CLA check ok. LGTM. manually merging |
@daph thanks for your patience and contribution to Logstash! |
This fixes issue #3, "RFC5424 output seems to format zone offset incorrectly"
Adding the second 'Z' to the timestamp format outputs the offset with the colon (see date format docs here). I tested this with syslog-ng as the receiving syslog and it now happily accepts RFC5424 messages sent to it via logstash-output-syslog where before it complained and wouldn't parse them.