Don't crash on error when send raises #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In certain cases (for example, when a UDP payload is too large), the send method can raise an exception, causing the plugin to crash. This commit will drop the event and log if this occurs.
jsvd
approved these changes
Feb 25, 2019
yaauie
reviewed
Feb 25, 2019
lib/logstash/outputs/udp.rb
Outdated
| logger.error("Failed to send event, message size of #{payload.size} too long", :error => e.inspect, | ||
| :backtrace => e.backtrace.first(10)) | ||
| rescue => e | ||
| logger.error("Failed to send event:", :error => e.inspect, |
There was a problem hiding this comment.
it may be helpful to output at least part of the event in question to the logs if we are effectively dropping it.
There was a problem hiding this comment.
In that case I'd suggest having a conditional to log the event if only in debug log level
…enabled Will output a truncated event payload if debug logging is enabled
|
Bump. Thanks @robbavey for this. This is a nice improvement but it considerably changes the semantic of the plugin which goes from crashing the pipeline upon any socket exception to dropping and moving on to next event in case of exception. The error handling semantics of output plugins in logstash in not well defined and our plugin behaviors range from crashing the pipeline to dropping event to having a retry policy. I suggest we move forward with this PR but also
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain cases (for example, when a UDP payload is too large),
the send method can raise an exception, causing the plugin to crash.
This commit will drop the event and log if this occurs.