Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid snappy transitive dependency #46

Merged
merged 6 commits into from Oct 3, 2023
Merged

Avoid snappy transitive dependency #46

merged 6 commits into from Oct 3, 2023

Conversation

andsel
Copy link
Contributor

@andsel andsel commented Oct 3, 2023

This PR removes the transitive dependencies from snappy and snappy-jars, instead it vendors the Xerial Snappy jar and uses it direclty.

@andsel andsel self-assigned this Oct 3, 2023
@andsel andsel marked this pull request as draft October 3, 2023 14:00
@andsel andsel marked this pull request as ready for review October 3, 2023 14:44
@jsvd jsvd self-requested a review October 3, 2023 14:50
jsvd
jsvd approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changelog tweak, otherwise LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
@andsel @jsvd
Better wording in changelog
8b031d6 
Co-authored-by: João Duarte <jsvd@users.noreply.github.com>
@andsel andsel merged commit e833c99 into logstash-plugins:main Oct 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsvd jsvd jsvd approved these changes

Assignees

@andsel andsel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andsel @jsvd