add '@' in USERNAME pattern #42
Conversation
Logins usually are email address. It would be so nice if grok could handle them out of the box.
|
Hi @veggiemonk, thanks a lot for your contribution. In order to move forward with your contribution you will need to sign the CLA, more info at -> https://www.elastic.co/contributor-agreement On the other side, we just added the option to test the grok patterns we've in here, adding test to validate your changes it will be cool to merge this in too. You can take inspiration to write the test from (https://github.com/logstash-plugins/logstash-patterns-core/blob/master/spec/patterns/syslog_spec.rb), don't heasitate to ask any question you might have, we'll be happy to provide help. |
|
Closing this for now as the CLA request got stale without an answer for long time, if you change your mind and sign the CLA we would be more than welcome to get this in. Thanks a lot for your contribution. |
Logins usually are email address. It would be so nice if grok could handle them out of the box.