Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add better stack contexts when running through 3rd party libs #12

Merged
merged 6 commits into from
Jun 1, 2022
Merged

Add better stack contexts when running through 3rd party libs #12

merged 6 commits into from
Jun 1, 2022

Conversation

adikus
Copy link
Contributor

@adikus adikus commented May 19, 2022 •
edited
Loading

Address all libraries we support:

  • winston
  • bunyan
  • koa doesn't really make sense to do it for Koa, since it's only logging HTTP requests

Fixes #5

@adikus adikus requested a review from gyfis May 19, 2022 17:05
gyfis
gyfis reviewed May 23, 2022
View reviewed changes
Copy link
Contributor

@gyfis gyfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adikus looks good! Can we add tests for this as well?

@adikus adikus requested a review from gyfis May 31, 2022 16:20
@adikus adikus merged commit 174eee0 into master Jun 1, 2022
@adikus adikus deleted the ah/better-stack-context branch January 9, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gyfis gyfis gyfis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updating the context.runtime.file_string context for the Winston logger
2 participants
@adikus @gyfis