Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(client): support clock tolerance config #736

Merged
merged 1 commit into from
Jun 18, 2024
Merged

feat(client): support clock tolerance config #736

merged 1 commit into from
Jun 18, 2024

Conversation

gao-sun
Copy link
Member

@gao-sun gao-sun commented Jun 18, 2024 •
edited
Loading

Summary

  • support clock tolerance config in DefaultJwtVerifier
  • allow set jwtVerifier after LogtoClient instance created

Testing

unit test added.

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

@gao-sun gao-sun force-pushed the gao-clock-tolerance-config branch 3 times, most recently from 220fffc to f39829c Compare June 18, 2024 09:29
@gao-sun gao-sun marked this pull request as ready for review June 18, 2024 09:41
@gao-sun gao-sun requested a review from wangsijie as a code owner June 18, 2024 09:41
@gao-sun gao-sun force-pushed the gao-clock-tolerance-config branch from f39829c to 775240f Compare June 18, 2024 09:51
@gao-sun gao-sun merged commit bf6fedc into master Jun 18, 2024
2 checks passed
@gao-sun gao-sun deleted the gao-clock-tolerance-config branch June 18, 2024 09:58
@xiaoyijun xiaoyijun mentioned this pull request Jun 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charIeszhao charIeszhao charIeszhao approved these changes

@wangsijie wangsijie Awaiting requested review from wangsijie wangsijie is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gao-sun @charIeszhao