refactor(core): add time window validation tolerance for otp authenticator #4684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/core/src/routes/interaction/utils/totp-validation.ts | 📉 -422 Bytes |
| packages/integration-tests/src/ui-helpers/expect-totp-experience.ts | 📉 -581 Bytes |
xiaoyijun
force-pushed
the
xiaoyijun-test-fix-totp-testing
branch
from
aff7b78
to
c1b38dc
Compare
xiaoyijun
changed the title
xiaoyijun
requested review from
simeng-li,
wangsijie and
gao-sun
as code owners
xiaoyijun
changed the title
wangsijie
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Considering T1 and T2 two consecutive time steps, any token generated within T1 but checked with T2 could be considered valid according to RFC 6238 5.2.
FYI: yeojz/otplib#697 (comment)
Updates
getUserIdFromDemoAppPagemethod from theExpectTotpExperienceclass since it's available in the base class(ExpectExperience).Testing
IT
Checklist
.changeset