Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): update first admin user preconditions #5858

Merged
merged 1 commit into from
May 14, 2024
Merged

refactor(core): update first admin user preconditions #5858

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/core/src/routes/interaction/actions/submit-interaction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ const getInitialUserRoles = (
isCreatingFirstAdminUser && !isCloud && defaultManagementApiAdminName // OSS uses the legacy Management API user role
);

// eslint-disable-next-line complexity -- @simeng refactor me
async function handleSubmitRegister(
interaction: VerifiedRegisterInteractionResult,
ctx: WithLogContext & WithInteractionDetailsContext & WithInteractionHooksContext,
Expand Down Expand Up @@ -113,8 +114,15 @@ async function handleSubmitRegister(
const { isCloud } = EnvSet.values;
const [currentTenantId] = await getTenantId(ctx.URL);
const isInAdminTenant = currentTenantId === adminTenantId;
/**
* Only allow creating the first admin user when it's in OSS or integration tests to avoid
* security issues.
*/
const isCreatingFirstAdminUser =
isInAdminTenant && String(client_id) === adminConsoleApplicationId && !(await hasActiveUsers());
(!EnvSet.values.isCloud || EnvSet.values.isIntegrationTest) &&
isInAdminTenant &&
String(client_id) === adminConsoleApplicationId &&
!(await hasActiveUsers());

// If it's Logto Cloud, Check if the new user has any pending invitations, if yes, skip onboarding flow.
const invitations =
Expand Down
Loading