docs(console): update the java spring guide #6133
Open
+40
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update the java spring guide
simeng-li
requested review from
wangsijie,
charIeszhao,
xiaoyijun and
gao-sun
as code owners
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/console/src/assets/docs/fragments/_redirect-uris-web.mdx | 📈 +34 Bytes |
| packages/console/src/assets/docs/guides/web-java-spring-boot/README.mdx | 📈 +772 Bytes |
gao-sun
reviewed
Jun 28, 2024
| @@ -13,6 +13,6 @@ Now, let's configure your redirect URI. E.g. {`${props.defaultUri ?? 'http://loc | |||
|
|
|||
| <UriInputField name="redirectUris" /> | |||
|
|
|||
| Just like signing in, users should be redirected to Logto for signing out of the shared session. Once finished, it would be great to redirect the user back to your website. For example, add `http://localhost:3000` as the post sign-out redirect URI below. | |||
| Just like signing in, users should be redirected to Logto for signing out of the shared session. Once finished, it would be great to redirect the user back to your website. For example, add {`${props.defaultLogoutUri ?? 'http://localhost:3000'}`} as the post sign-out redirect URI below. | |||
There was a problem hiding this comment.
Suggested change
| Just like signing in, users should be redirected to Logto for signing out of the shared session. Once finished, it would be great to redirect the user back to your website. For example, add {`${props.defaultLogoutUri ?? 'http://localhost:3000'}`} as the post sign-out redirect URI below. | |
| Just like signing in, users should be redirected to Logto for signing out of the shared session. Once finished, it would be great to redirect the user back to your website. For example, add {`${props.defaultSignOutUri ?? 'http://localhost:3000'}`} as the post sign-out redirect URI below. |
gao-sun
reviewed
Jun 28, 2024
| @@ -268,7 +258,7 @@ home.html: | |||
|
|
|||
| Create a new controller to handle the user page: | |||
|
|
|||
| ```java | |||
| ```java title="UserController.java" | |||
There was a problem hiding this comment.
could you move "Get user info" after "Checkpoint"?
There was a problem hiding this comment.
Rename the title to Create user page. Besides displaying user information, this section also handles the sign-out logic and the after sign-in redirect logic. Keeping it in the current order ensures a more fluent reading experience. .
polish springboot docs
rename the section title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update the Java Spring guide
Testing
Checklist
.changeset